Project

General

Profile

Actions
Copy link

Task #60059

closed

Create a Getter for the CacheManager inside Datahandler class

Added by Stefano Kowalke almost 10 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Stefano Kowalke
Category:
Code Cleanup
Target version:
7.0
Start date:
2014-07-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
easy
Sprint Focus:

Description

At the moment the CacheManager is created by 

GeneralUtility::makeInstance('TYPO3\\CMS\\Core\\Cache\\CacheManager');
within the code. This makes the particular method untestable.

Solution: Create a Getter which creates and returns the instance. This getter can be mocked.

Actions
Copy link
 #1

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31288

Actions
Copy link
 #2

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31289

Actions
Copy link
 #3

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31289

Actions
Copy link
 #4

Updated by Stefano Kowalke almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project TYPO3CMS/Extensions/solr has been pushed to the review server.
It is available at https://review.typo3.org/31322

Actions
Copy link
 #6

Updated by Wouter Wolters over 9 years ago

  • Status changed from Under Review to Closed

reopened by accident

Actions
Copy link

Also available in: Atom PDF