Bug #60405

PageTree cannot select/expand hidden nodes

Added by Oliver Hader over 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Pagetree
Target version:
-
Start date:
2014-07-20
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

TYPO3.Backend.NavigationContainer.PageTree.select(64) does not select the correct page, but tries to determine the correct node levels, fakes the local node states and reloads the page tree. One thing that might not be considered there is the fact that pages are represented in hex-values with a leading "p", thus the integer "64" with be converted to "p40" as node id.

To overcome this scenario and enable custom handling there, a new generic method is introduced:
TYPO3.Backend.NavigationContainer.PageTree.invokePageId(pageId, callback, allResults);

The methods "selectPageId" and "expandPageId" show how this is actually used.


Related issues

Related to TYPO3 Core - Feature #60406: Highlight page tree depending on current workspace element Closed 2014-07-20

Associated revisions

Revision 9aaab9b3 (diff)
Added by Oliver Hader about 4 years ago

[BUGFIX] PageTree cannot select/expand hidden nodes

TYPO3.Backend.NavigationContainer.PageTree.select(64) does not
select the correct page, but tries to determine the correct node
levels, fakes the local node states and reloads the page tree.
One thing that might not be considered there is the fact that
pages are represented in hex-values with a leading "p", thus
the integer "64" will be converted to "p40" as node id.

To overcome this scenario and enable custom handling there,
a new generic method is introduced:
TYPO3.Backend.NavigationContainer.PageTree
.invokePageId(pageId, callback, allResults);

The methods "selectPageId" and "expandPageId" show how this
is actually used.

Resolves: #60405
Releases: master, 7.6
Change-Id: If24b1a0ec261e9bcf00d214bf10c4b4a0aa5bed5
Reviewed-on: https://review.typo3.org/32155
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

Revision 56d48602 (diff)
Added by Oliver Hader about 4 years ago

[BUGFIX] PageTree cannot select/expand hidden nodes

TYPO3.Backend.NavigationContainer.PageTree.select(64) does not
select the correct page, but tries to determine the correct node
levels, fakes the local node states and reloads the page tree.
One thing that might not be considered there is the fact that
pages are represented in hex-values with a leading "p", thus
the integer "64" will be converted to "p40" as node id.

To overcome this scenario and enable custom handling there,
a new generic method is introduced:
TYPO3.Backend.NavigationContainer.PageTree
.invokePageId(pageId, callback, allResults);

The methods "selectPageId" and "expandPageId" show how this
is actually used.

Resolves: #60405
Releases: master, 7.6
Change-Id: If24b1a0ec261e9bcf00d214bf10c4b4a0aa5bed5
Reviewed-on: https://review.typo3.org/47443
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32155

#2 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32155

#3 Updated by Gerrit Code Review about 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32155

#4 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32155

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32155

#6 Updated by Gerrit Code Review over 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32155

#7 Updated by Gerrit Code Review about 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/32155

#8 Updated by Gerrit Code Review about 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/32155

#9 Updated by Gerrit Code Review about 4 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/32155

#10 Updated by Oliver Hader about 4 years ago

How to test?

  • Apply the patch
  • Clear all caches using the Install Tool (ExtDirect cache must be flushed)
  • Find a nested page somewhere in the page tree and notice the page ID
  • collapse all page branches
  • reload the whole backend
  • open the browser console and e.g. type (replace the number "20" with the page ID you've chosen)
TYPO3.Backend.NavigationContainer.PageTree.selectPageId(20);

or

TYPO3.Backend.NavigationContainer.PageTree.expandPageId(20);

#11 Updated by Gerrit Code Review about 4 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/32155

#12 Updated by Gerrit Code Review about 4 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47443

#13 Updated by Oliver Hader about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#14 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF