Project

General

Profile

Actions

Bug #60514

closed

Database analyzer does not parse TEXT null / not null fields

Added by Christian Kuhn over 10 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Should have
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2014-07-24
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Suppose you have a column defined as TEXT in a table, it will be implicit NULL.

CREATE TABLE fe_groups (
description text
);

If this column exists and the definition is later changed to "NOT NULL", the database analyzer does not recognize this change and thinks everything is fine.

CREATE TABLE fe_groups (
description text NOT NULL,
);

The db analyzer code should issue this command:

ALTER TABLE `fe_groups` CHANGE `description` `description` TEXT NOT NULL;

The same issue exists vice versa: If a field in NOT NULL and is changed to allow NULL as default.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #60245: Database table structure for fe_groups is incompleteClosed2014-07-10

Actions
Related to TYPO3 Core - Bug #64616: Compare Database does not remove 'NOT NULL'Closed2015-01-29

Actions
Actions #1

Updated by Morton Jonuschat over 9 years ago

  • Assignee set to Morton Jonuschat
Actions #2

Updated by Morton Jonuschat over 9 years ago

  • Status changed from New to Needs Feedback

I just tried to validate this on 6.2.14 and couldn't reproduce with a clean table. Switching between NOT NULL and NULL works flawlessly.

The examples given in the ticket have one problem, the field type is written in uppercase (TEXT) instead of lowercase (text).
This leads to upgrade suggestions in the install tool that can not be implemented and will always show up.

Actions #3

Updated by Morton Jonuschat over 9 years ago

  • Status changed from Needs Feedback to Closed

This bug has been fixed through issue #64616

Actions

Also available in: Atom PDF