Bug #60559

Clean up backend login controller Part 1

Added by Christian Kuhn about 5 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
Start date:
2014-07-25
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.5
Tags:
Complexity:
medium
Is Regression:
No
Sprint Focus:

Associated revisions

Revision 5b035057 (diff)
Added by Christian Kuhn about 5 years ago

[TASK] Clean up backend login controller Part 1

To prepare a switch of the backend login view to a fluid rendered
template, the current controller is first simlpfied a bit and some
ancient code is removed.

With t3skin, the default template of ext:backend/.../login.html is
always overloaded by ext:t3skin/.../login.html. The patch overwrites
the content of the ext:backend template with the content from
ext:login and removes the template and overload registration in
ext:login.

The old template in ext:backend was not used for a very long time
but includes some old handling like loginBoxImage_rotationFolder
encapsulated in makeLoginBoxImage(). This code is dropped without
substitution.

References to two ancient login images are dropped with the removal
of makeLoginBoxImage() and can be finally removed along the way.

Change-Id: I057fbe062b138ab4f428e49e511bc46363a8a7ed
Resolves: #60559
Releases: 6.3
Reviewed-on: http://review.typo3.org/31802
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Benjamin Mack <>
Tested-by: Benjamin Mack <>

History

#1 Updated by Christian Kuhn about 5 years ago

  • Subject changed from Clean up backend login controller to Clean up backend login controller Part 1

#2 Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31802

#3 Updated by Gerrit Code Review about 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31802

#4 Updated by Gerrit Code Review about 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31802

#5 Updated by Christian Kuhn about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF