Project

General

Profile

Actions

Task #60574

closed

Deprecate all client related condition matchers

Added by Christian Kuhn almost 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Miscellaneous
Target version:
Start date:
2014-07-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.5
Tags:
Complexity:
easy
Sprint Focus:

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #41801: TypoScript browser conditions don't generate Vary: User-Agent headerClosed2012-10-09

Actions
Actions #1

Updated by Christian Kuhn almost 10 years ago

Conditions that depend on client details are unlovely for a number of reasons:

  • Per condition or permutation of conditions that matches, the frontend creates a different cache entry. This can lead to a very high number of cache entrys per page
  • Most usual conditions for specific browsers can nowadays turned into conditional CSS includes
  • Conditions based on browser or clients on server side are bad practice
  • If conditions for specific clients or devices are still needed, they should be done with a userFunc condition and a project like WURFL that keep the device information more recent than the current core code like matching AMIGA
  • Setups like reverse proxies give additional headaches with these types of conditions

All client related condition types are deprecated with this patch.

Actions #2

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31820

Actions #3

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31820

Actions #4

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31820

Actions #5

Updated by Anonymous almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF