Task #60574

Deprecate all client related condition matchers

Added by Christian Kuhn over 5 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Miscellaneous
Target version:
Start date:
2014-07-25
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.5
Tags:
Complexity:
easy
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #41801: TypoScript browser conditions don't generate Vary: User-Agent header Closed 2012-10-09
Precedes TYPO3 Core - Bug #63522: Deprecate the "device" TypoScript condition Closed 2014-12-02

Associated revisions

Revision 742c8bfa (diff)
Added by Sascha Egerer about 5 years ago

[!!!][TASK] Deprecate all client related condition matchers

Conditions that depend on client details are unlovely for a number
of reasons:

  • Per condition or permutation of conditions that matches, the frontend
    creates a different cache entry. This can lead to a very high number
    of cache entrys per page
  • Most usual conditions for specific browsers can nowadays turned into
    conditional CSS includes
  • Conditions based on browser or clients on server side are
    bad practice.
  • If conditions for specific clients or devices are still needed, they
    should be done with a userFunc condition and a project like WURFL
    that keep the device information more recent than the current core
    code like matching AMIGA
  • Setups like reverse proxies give additional headaches with these
    types of conditions
  • All client related condition types are deprecated with this patch.

Resolves: #60574
Releases: 6.3
Change-Id: Ib9e78748e87a2f7e04fa1b606415ad1d8d302374
Reviewed-on: http://review.typo3.org/31820
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

Revision 42e86727 (diff)
Added by Georg Ringer almost 5 years ago

[!!!][TASK] Deprecate "device" TypoScript condition

The TS condition for the device has been forgotten in
issue #60574 and is deprecated now.

Resolves: #63522
Related: #60574
Releases: master
Change-Id: I466125afe1f1398fa892d28cc8f7515181e82ca0
Reviewed-on: http://review.typo3.org/35402
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Frank Nägler <>
Tested-by: Frank Nägler <>

History

#1 Updated by Christian Kuhn over 5 years ago

Conditions that depend on client details are unlovely for a number of reasons:

  • Per condition or permutation of conditions that matches, the frontend creates a different cache entry. This can lead to a very high number of cache entrys per page
  • Most usual conditions for specific browsers can nowadays turned into conditional CSS includes
  • Conditions based on browser or clients on server side are bad practice
  • If conditions for specific clients or devices are still needed, they should be done with a userFunc condition and a project like WURFL that keep the device information more recent than the current core code like matching AMIGA
  • Setups like reverse proxies give additional headaches with these types of conditions

All client related condition types are deprecated with this patch.

#2 Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31820

#3 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31820

#4 Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31820

#5 Updated by Anonymous about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF