Project

General

Profile

Actions

Bug #61506

closed

Salted passwords are not imported from t3d using import/export module

Added by Nils Heuermann over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Authentication
Target version:
Start date:
2014-09-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.5
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When importing a t3d file using the import/export module of Typo3 and the saltedpasswords extension is enabled user passwords will not be imported if they are already salted.

The method evaluateFieldValue in TYPO3\CMS\Saltedpasswords\Evaluation\Evaluator sets the "set" flag to false when saltedpasswords are enabled. After that there are some checks for the password hash method that might have processed the password value.

The problem is that IF the password is already a salted password, the "set" flag remains false - and therefore the imported password hash is not saved to the database.

To reproduce this:
- Export a page tree (t3d) with be_users or fe_users (which have a salted password stored in the database)
- Import t3d file
- Passwords of imported users are empty

Actions #1

Updated by Vlatko Šurlan about 9 years ago

I can confirm this. It happens also in the more narrow case when you export/import just the fe_users record.

Actions #2

Updated by Gerrit Code Review about 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35614

Actions #3

Updated by Markus Klein about 9 years ago

  • Target version set to next-patchlevel

Please test if the linked patch solves the problem. I didn't test the patch though.

Actions #4

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35614

Actions #5

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35614

Actions #6

Updated by Gerrit Code Review about 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35614

Actions #7

Updated by Markus Klein about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Gerrit Code Review about 9 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36409

Actions #9

Updated by Markus Klein about 9 years ago

  • Status changed from Under Review to Resolved
Actions #10

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF