Bug #61617

Absolute publicUrls of images are prepended with relative prefixes

Added by Franz Koch about 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
Start date:
2014-09-15
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The ImageService->getImageUri() method prepends the publicUrl of file objects with prefixes without checking if the URL is already absolute. I stumbled over this issue because the FAL driver I have implemented is connecting an external image database where the images are hosted externally and local processing is not allowed.

Associated revisions

Revision 4ecb81cf (diff)
Added by Franz Koch about 5 years ago

[BUGFIX] Don't prepend absolute image URLs

The ImageService->getImageUri() method always prepends the public URL of
the image object with a prefix, regardless whether the object already
returns a fully qualified URL. This can be the case when the FAL driver
is connecting a remote image storage that doesn't allow local processing
and requires the images to be loaded from the remote server.

Change-Id: Iac65bc93bc0d1c1cbeb2335b7e13fc2126b728b6
Resolves: #61617
Releases: 6.2, 6.3
Reviewed-on: http://review.typo3.org/32786
Reviewed-by: Wouter Wolters <>
Reviewed-by: Franz Koch <>
Reviewed-by: Alexander Opitz <>
Tested-by: Alexander Opitz <>
Reviewed-by: Stefan Froemken <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 51b2ad5e (diff)
Added by Franz Koch about 5 years ago

[BUGFIX] Don't prepend absolute image URLs

The ImageService->getImageUri() method always prepends the public URL of
the image object with a prefix, regardless whether the object already
returns a fully qualified URL. This can be the case when the FAL driver
is connecting a remote image storage that doesn't allow local processing
and requires the images to be loaded from the remote server.

Change-Id: Iac65bc93bc0d1c1cbeb2335b7e13fc2126b728b6
Resolves: #61617
Releases: 6.2, 6.3
Reviewed-on: http://review.typo3.org/32799
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32786

#2 Updated by Gerrit Code Review about 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32786

#3 Updated by Gerrit Code Review about 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32786

#4 Updated by Gerrit Code Review about 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32786

#5 Updated by Gerrit Code Review about 5 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32799

#6 Updated by Franz Koch about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF