Project

General

Profile

Actions
Copy link

Bug #62104

closed

LocalDriver::getFileInfoByIdentifier can be optimised

Added by Michiel Roos about 10 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2014-10-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

\TYPO3\CMS\Core\Resource\Driver\LocalDriver::getFileInfoByIdentifier() fetches the dirPath of the given $fileIdentifier at the start of the method.

This information is not used untill the last line of the method.

The method may fail if the resource does not exist. By that time, some work was performed that was not needed.

I suggest moving the $dirPath calculation to the bottom of the method.

Actions
Copy link

Also available in: Atom PDF