Project

General

Profile

Actions

Bug #63666

closed

Bug #63692: Memory consumption while bulk inserting

High memory consumption in BackendUtility->getTCAtypes while bulk inserting

Added by Stephan Großberndt about 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Performance
Target version:
Start date:
2014-12-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

DataHandler->fillInFieldArray calls

$types_fieldConfig = BackendUtility::getTCAtypes($table, $currentRecord);
for each record to insert. In each call the type of the current record is checked and the complete types configuration is parsed again.

static public function getTCAtypes($table, $rec, $useFieldNameAsKey = 0) {
    if ($GLOBALS['TCA'][$table]) {
    // Get type value:
    $fieldValue = self::getTCAtypeValue($table, $rec);
    // Get typesConf
    $typesConf = $GLOBALS['TCA'][$table]['types'][$fieldValue];
    // Get fields list and traverse it
    $fieldList = explode(',', $typesConf['showitem']);
    $altFieldList = array();
    // Traverse fields in types config and parse the configuration into a nice array:
    foreach ($fieldList as $k => $v) {
        [...]
    }
    if ($useFieldNameAsKey) {
        $fieldList = $altFieldList;
    }
    // Return array:
    return $fieldList;
}

A new static cache using tablename, type and parameter as key improves performance and memory consumption:

static public function getTCAtypes($table, $rec, $useFieldNameAsKey = 0) {
    static $tcaTableTypeConf_cache = array();

    if ($GLOBALS['TCA'][$table]) {
    // Get type value:
    $fieldValue = self::getTCAtypeValue($table, $rec);

    if ($tcaTableTypeConf_cache[$table . 'type' . $fieldValue . 'fnk' . $useFieldNameAsKey]) {
        return $tcaTableTypeConf_cache[$table . 'type' . $fieldValue . 'fnk' . $useFieldNameAsKey];
    }

    // Get typesConf
    $typesConf = $GLOBALS['TCA'][$table]['types'][$fieldValue];
    // Get fields list and traverse it
    $fieldList = explode(',', $typesConf['showitem']);
    $altFieldList = array();
    // Traverse fields in types config and parse the configuration into a nice array:
    foreach ($fieldList as $k => $v) {
        [...]
    }
    if ($useFieldNameAsKey) {
        $fieldList = $altFieldList;
    }

    $tcaTableTypeConf_cache[$table . 'type' . $fieldValue . 'fnk' . $useFieldNameAsKey] = $fieldList;
    // Return array:
    return $fieldList;
}
For bulk insert of 6500 typeless (only type '1') records:
  • 465000 calls less
  • 3.3 seconds faster
  • memory usage of explode()-Function down from 128MB to 58MB
Actions #1

Updated by Philipp Gampe about 9 years ago

  • Parent task set to #63692
Actions #2

Updated by Gerrit Code Review about 9 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35185

Actions #3

Updated by Gerrit Code Review about 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35185

Actions #4

Updated by Gerrit Code Review about 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35185

Actions #5

Updated by Gerrit Code Review about 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35185

Actions #6

Updated by Gerrit Code Review about 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35185

Actions #7

Updated by Gerrit Code Review about 9 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35185

Actions #8

Updated by Gerrit Code Review about 9 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35185

Actions #9

Updated by Gerrit Code Review about 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35521

Actions #10

Updated by Stephan Großberndt about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF