Bug #63780

Bug #63692: Memory consumption while bulk inserting

Do not collect unused words_strings in ReferenceIndex->generateRefIndexData

Added by Stephan Großberndt almost 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Performance
Target version:
Start date:
2014-12-11
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

In ReferenceIndex->generateRefIndexData the strings from all input and text fields are collected in $this->word_strings. But the array is never accessed. Not in TYPO3 7. Neither in TYPO3 6.2. Neither in TYPO3 4.5. sigh :.-(

Associated revisions

Revision 7240297a (diff)
Added by Stephan Großberndt almost 5 years ago

[!!!][TASK] Remove words and words_strings from ReferenceIndex

In ReferenceIndex->generateRefIndexData the strings from all input and
text fields were collected in $this->word_strings. But the array was
never accessed. Remove ReferenceIndex->words (unused) and
ReferenceIndex->word_strings and the collection of word_strings. This
greatly reduces memory usage when bulk inserting or editing records as
well as updating the reference index.

Resolves: #63780
Releases: master, 6.2
Change-Id: I56d6a3e615cab44cbecff5a7d4dec42a1da29fc6
Reviewed-on: http://review.typo3.org/35310
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 5401e75f (diff)
Added by Stephan Großberndt almost 5 years ago

[!!!][TASK] Remove words and words_strings from ReferenceIndex

In ReferenceIndex->generateRefIndexData the strings from all input and
text fields were collected in $this->word_strings. But the array was
never accessed.

While both properties were removed in master, the 6.2 backport keeps
the properties, but does not fill word_strings anymore, so the patch
is less breaking but the performance improvement is still given.

Resolves: #63780
Releases: master, 6.2
Change-Id: I56d6a3e615cab44cbecff5a7d4dec42a1da29fc6
Reviewed-on: http://review.typo3.org/35349
Reviewed-by: Stephan Großberndt <>
Tested-by: Stephan Großberndt <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#2 Updated by Gerrit Code Review almost 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35310

#3 Updated by Mathias Schreiber almost 5 years ago

  • Parent task set to #63692

#4 Updated by Gerrit Code Review almost 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35310

#5 Updated by Gerrit Code Review almost 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35310

#6 Updated by Gerrit Code Review almost 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35310

#7 Updated by Gerrit Code Review almost 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35310

#8 Updated by Gerrit Code Review almost 5 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35349

#9 Updated by Stephan Großberndt almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF