Bug #63784: Do not check for generated key in possibly empty array in DataHandler->fillInFieldArray - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #63784

closed

Bug #63692: Memory consumption while bulk inserting

Do not check for generated key in possibly empty array in DataHandler->fillInFieldArray

Added by Stephan Großberndt over 9 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Stephan Großberndt

Category:

Performance

Target version:

next-patchlevel

Start date:

2014-12-11

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

no-brainer

Is Regression:

Sprint Focus:

Description

If $this->exclude_array is empty its not necessary to check for the existence.

foreach ($incomingFieldArray as $field => $fieldValue) {
    if (!in_array(($table . '-' . $field), $this->exclude_array) && !$this->data_disableFields[$table][$id][$field]) {

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

Actions

Copy link

Updated by Mathias Schreiber over 9 years ago

Parent task set to #63692

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

Actions

Copy link

#10

Updated by Gerrit Code Review about 9 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

Actions

Copy link

#11

Updated by Gerrit Code Review about 9 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35315

Actions

Copy link

#12