Project

General

Profile

Actions

Task #64064

closed

Revert #56771 which introduced brittle feature + tests to validEmail() which were beyond the scope of the function

Added by Steffen Müller over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2014-12-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The purpose of GeneralUtility::validEmail() as stated in the comment is: "Checking syntax of input email address".
#56771 introduced a mechanism to validate if the underlying infrastructure (DNS) can verify if an MX record was set for the domain part of the given email.

This feature should be reverted for several reasons:
1. The MX query check is beyond the scope of the function.
2. Validating email addresses by coupling the underlying DNS infrastructure is brittle and subject to fail on certain environments (no network, no proper DNS resolver, intranet, local dev, ...). It might lead to false negatives, which is for example the case for root@localhost
3. The corresponding unit tests are also brittle, since they rely on a proper DNS setup for the test fixtures and available DNS resolver in test environment.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #56771: Additional check for valid domain in validEmail()RejectedBenni Mack2014-03-11

Actions
Actions #1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35683

Actions #2

Updated by Steffen Müller over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #3

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF