Task #64064
closedRevert #56771 which introduced brittle feature + tests to validEmail() which were beyond the scope of the function
100%
Description
The purpose of GeneralUtility::validEmail()
as stated in the comment is: "Checking syntax of input email address".
#56771 introduced a mechanism to validate if the underlying infrastructure (DNS) can verify if an MX record was set for the domain part of the given email.
This feature should be reverted for several reasons:
1. The MX query check is beyond the scope of the function.
2. Validating email addresses by coupling the underlying DNS infrastructure is brittle and subject to fail on certain environments (no network, no proper DNS resolver, intranet, local dev, ...). It might lead to false negatives, which is for example the case for root@localhost
3. The corresponding unit tests are also brittle, since they rely on a proper DNS setup for the test fixtures and available DNS resolver in test environment.
Updated by Gerrit Code Review almost 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35683
Updated by Steffen Müller almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset c521f3b578f7e1ddce3043ed84ee2caafefbb060.