Bug #64281: Backend PageLayoutView.php shows wrong Image Caption field - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #64281

closed

Backend PageLayoutView.php shows wrong Image Caption field

Added by stefan schreck almost 10 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Backend User Interface

Target version:

Start date:

2015-01-14

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

5.5

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

Shows imagecaption from OLD field "imagecaption" from tt_content instead of NEW “Description” from FAL.

PageLayoutView.php line 1491

if ($row['imagecaption']) {
$out .= $this->linkEditContent($this->renderText($row['imagecaption']), $row) . '<br />';
}

Files

Download all files

64281_before.png (24.9 KB) 64281_before.png		Mathias Schreiber, 2015-01-14 17:16
64281_after.png (27.7 KB) 64281_after.png		Mathias Schreiber, 2015-01-14 17:16

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36013

Actions

Copy link Download all files

Updated by Mathias Schreiber almost 10 years ago

File 64281_before.png 64281_before.png added
File 64281_after.png 64281_after.png added

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36013

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36013

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36013

Actions

Copy link

Updated by Mathias Schreiber almost 10 years ago

Hey Stefan,

we need to define the expected behavior here.
Given you add like 20 Images, would you expect all captions to be shown?
We cut off the bodytext after 1500 characters, how would you handle this with captions?

Actions

Copy link

Updated by stefan schreck almost 10 years ago

Mathias Schreiber wrote:

Hey Stefan,

we need to define the expected behavior here.
Given you add like 20 Images, would you expect all captions to be shown?
We cut off the bodytext after 1500 characters, how would you handle this with captions?

Hi there,
Since the caption is almost never that long it would be nice to see it all.
A crop nevertheless can't be wrong.
Just my opinion
Stefan

Actions

Copy link

Updated by Mathias Schreiber almost 10 years ago

Status changed from Under Review to New

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Status changed from New to Under Review

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36013

Actions

Copy link

#10

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36099

Actions

Copy link

#11