Project

General

Profile

Actions

Task #64663

closed

Make use of phpunit after tearDown execution

Added by Anja Leichsenring almost 10 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Won't have this time
Category:
Tests
Target version:
-
Start date:
2015-01-30
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:

Description

Since a latest release of phpunit it is possible to tag a function as to be executed after frameworks tearDown().

Evaluate and implement:
  • rename ext:core\Tests\UnitTestCase::tearDown() to something speaking, tag it as executed after each test.
  • find all calls to parent::tearDown() inside the unit test files and remove them
  • do not touch Test classes in contrib or Packages/Library directories, because we must not change third party code.
Actions #1

Updated by Mateusz Wojtuła almost 10 years ago

  • Status changed from New to In Progress
  • Assignee set to Mateusz Wojtuła
Actions #2

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36475

Actions #3

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36475

Actions #4

Updated by Anja Leichsenring almost 10 years ago

  • Status changed from Under Review to Closed
  • Priority changed from Should have to Won't have this time

I am sorry about the bad news, but we found out meanwhile, that the @after annotated function is only executed in the test class it belongs to. So no global implementation is possible at this point.

Actions #5

Updated by Anja Leichsenring almost 9 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions

Also available in: Atom PDF