Actions
Bug #64929
closedFix filesize Unittest on windows with CRLF
Start date:
2015-02-08
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:
Stabilization Sprint
Description
If you use autocrlf = true the hardcoded filesize of Dummy.html in TYPO3\CMS\Core\Tests\Unit\Resource\Driver\LocalDriverTest::getSpecificFileInformationDataProvider of 48 bytes does not match the actual filesize of 53 bytes.
This leads to a unit test failure:
1) TYPO3\CMS\Core\Tests\Unit\Resource\Driver\LocalDriverTest::getSpecificFileInformationReturnsRequestedFileInformation with data set "size" (48, 'size') Failed asserting that 53 is identical to 48. D:\typo3\master\typo3\sysext\core\Tests\Unit\Resource\Driver\LocalDriverTest.php:350 D:\typo3\master\Packages\Libraries\phpunit\phpunit\phpunit:36
Instead of using a hardcoded filesize it should be read from the filesystem. (See https://review.typo3.org/#/c/31256/14)
Updated by Gerrit Code Review over 9 years ago
- Status changed from In Progress to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36743
Updated by Stephan Großberndt over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f1ceb275037dbd06567eeec2c3d07512b923c9c1.
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from Resolved to Closed
Actions