Bug #64966

fe_login Usergroup redirect fails

Added by Simon Brandstätter over 4 years ago. Updated 8 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2015-02-10
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

I have a own sv1 extension where a new User is made over webservice with usergroups. The groups are not saved asc. (eg. 12,11,15,10,13).
If the new user log in he should be redirected to a page which is defined in group.
But in the FrontendLoginController.php (663) there is a DB select where the in statement becomes wrong:
implode(',', $groupData['uid']) ... but this gives ,10,11,12,13,15 so there was an empty array element.
So the code must become:
array_filter($groupData['uid']) and everything is fine.

Associated revisions

Revision f0b9136e (diff)
Added by Frederic Gaus over 3 years ago

[BUGFIX] Avoid wrong SQL query in fe_login user group redirect

Ensure that no invalid group data is collected and check
if any group is set at all before running the SQL query.

Change-Id: I5792ff606d60ba5e5a108ed18c2ec91e354f85ff
Resolves: #64966
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/39447
Reviewed-by: Morton Jonuschat <>
Tested-by: Morton Jonuschat <>
Reviewed-by: Benni Mack <>
Reviewed-by: Wouter Wolters <>
Tested-by: Markus Klein <>

Revision 72ebfbfa (diff)
Added by Frederic Gaus over 3 years ago

[BUGFIX] Avoid wrong SQL query in fe_login user group redirect

Ensure that no invalid group data is collected and check
if any group is set at all before running the SQL query.

Change-Id: I5792ff606d60ba5e5a108ed18c2ec91e354f85ff
Resolves: #64966
Releases: master, 6.2
Reviewed-on: https://review.typo3.org/45131
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Simon Brandstätter over 4 years ago

Simon Brandstätter wrote:

I have a own sv1 extension where a new User is made over webservice with usergroups. The groups are not saved asc. (eg. 12,11,15,10,13).
If the new user log in he should be redirected to a page which is defined in group.
But in the FrontendLoginController.php (line 663 Typo3 6.2.9) there is a DB select where the in statement becomes wrong:
implode(',', $groupData['uid']) ... but this gives ,10,11,12,13,15 so there was an empty array element.
So the code must become:
implode(',', array_filter($groupData['uid'])) and everything is fine.

#2 Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39447

#3 Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39447

#4 Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39447

#5 Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39447

#6 Updated by Mathias Schreiber over 3 years ago

  • Target version deleted (next-patchlevel)

#7 Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/39447

#8 Updated by Frederic Gaus over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45131

#10 Updated by Frederic Gaus over 3 years ago

  • Status changed from Under Review to Resolved

#11 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF