Bug #65248
closedStorage indexing task should not catch exception
100%
Description
The FileStorageIndexingTask
catches any exception that may happen during indexing and returns FALSE
in case anything happens.
This is not the proper way for tasks. Instead they should let the error bubble up and the Scheduler handle the display of the related error.
Example use case: imagine that you have a badly screwed file name (users are creative) like foo\bar.txt
. FAL will choke upon such a file name. Currently the Scheduler BE module will report the error as:
"Execution of task "File Abstraction Layer: Update storage index (scheduler)" failed with the following message: Task failed to execute successfully. Class: TYPO3\CMS\Scheduler\Task\FileStorageIndexingTask, UID: 8"
By letting the exception bubble up, we get this instead:
"Execution of task "File Abstraction Layer: Update storage index (scheduler)" failed with the following message: File /user_upload/foo\bar.txt does not exist."
which is far more useful in trying to solve the problem.
Updated by Gerrit Code Review almost 10 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37156
Updated by Gerrit Code Review almost 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37156
Updated by Gerrit Code Review almost 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37424
Updated by Francois Suter almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset da47355b807300538f772325f45a31a7f1cf8817.