Project

General

Profile

Actions

Bug #65320

closed

Epic #65314: PHP7

BooleanNodeTest::convertToBooleanProperlyConvertsNumericValues

Added by Alexander Opitz about 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2015-02-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

TYPO3\CMS\Fluid\Tests\Unit\Core\Parser\SyntaxTree\BooleanNodeTest::convertToBooleanProperlyConvertsNumericValues
Failed asserting that true is false.

/home/opitz/projects/typo3-master/typo3-src/typo3/sysext/fluid/Tests/Unit/Core/Parser/SyntaxTree/BooleanNodeTest.php:422
/home/opitz/projects/neos-git/Packages/Libraries/phpunit/phpunit/phpunit7:56

=> is_numeric handling changed for string, is_numeric('0x0') with 5.x TRUE, with 7.0 FALSE

=> Only change test or has this any relevance elsewhere?

Actions #1

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39745

Actions #2

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39745

Actions #3

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39782

Actions #4

Updated by Alexander Opitz almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF