Project

General

Profile

Actions

Bug #65666

closed

typolink, typolinkEnableLinksAcrossDomains and forceAbsoluteUrl strips absRefPrefix

Added by Markus Klein over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Frontend
Target version:
Start date:
2015-03-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Environment

  • no realurl
  • config.typolinkEnableLinksAcrossDomains= 1
  • config.absRefPrefix = /site/

Reproduce

use this TypoScript snippet:

link = TEXT
link.typolink {
  parameter = 66
  forceAbsoluteUrl = 1
  additionalParams = &tx_ext_pi1[controller]=Controller
  returnLast = url
}

The expected result would be:

http://dev/site/index.php?id=66&tx_ext_pi1%5Bcontroller%5D=Controller

The actual result is:

http://dev/index.php?id=66&tx_ext_pi1%5Bcontroller%5D=Controller

Solution

In the typolink() function there is a wrong assumption about the content of $targetDomain.

If we have domain here it means we link across domains...

If forceAbsoluteUrl is set $targetDomain will contain the current domain.
A check for this case needs to be added.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #63954: typolink_URL ignores forceAbsoluteUrlClosed2014-12-17

Actions
Actions #1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37730

Actions #2

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37733

Actions #3

Updated by Markus Klein over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF