Bug #66028

Use early return in cObj::getImgResource

Added by Oliver Hader over 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Performance
Target version:
-
Start date:
2015-03-25
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.5
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

If ContentObjectRenderer::getImgResource is called without any data, there is no need to execute all possibilities and lookup files with an empty identifier. For instance TextMenuContentObject::getBeforeAfter triggers this at lot.

Associated revisions

Revision e26def8c (diff)
Added by Oliver Hader over 4 years ago

[BUGFIX] Use early return in cObj::getImgResource

If ContentObjectRenderer::getImgResource is called without any
data, there is no need to execute all possibilities and lookup
files with an empty identifier.
For instance TextMenuContentObject::getBeforeAfter triggers
this at lot.

Resolves: #66028
Releases: master, 6.2
Change-Id: Iee7a3ce0f2956cd6ddae8c2e3d194f3cf2855c49
Reviewed-on: http://review.typo3.org/38162
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision a3358657 (diff)
Added by Oliver Hader over 4 years ago

[BUGFIX] Use early return in cObj::getImgResource

If ContentObjectRenderer::getImgResource is called without any
data, there is no need to execute all possibilities and lookup
files with an empty identifier.
For instance TextMenuContentObject::getBeforeAfter triggers
this at lot.

Resolves: #66028
Releases: master, 6.2
Change-Id: Iee7a3ce0f2956cd6ddae8c2e3d194f3cf2855c49
Reviewed-on: http://review.typo3.org/38223
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38162

#2 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38162

#3 Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38223

#4 Updated by Oliver Hader over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF