Bug #66028
Use early return in cObj::getImgResource
100%
Description
If ContentObjectRenderer::getImgResource is called without any data, there is no need to execute all possibilities and lookup files with an empty identifier. For instance TextMenuContentObject::getBeforeAfter triggers this at lot.
Associated revisions
[BUGFIX] Use early return in cObj::getImgResource
If ContentObjectRenderer::getImgResource is called without any
data, there is no need to execute all possibilities and lookup
files with an empty identifier.
For instance TextMenuContentObject::getBeforeAfter triggers
this at lot.
Resolves: #66028
Releases: master, 6.2
Change-Id: Iee7a3ce0f2956cd6ddae8c2e3d194f3cf2855c49
Reviewed-on: http://review.typo3.org/38162
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
[BUGFIX] Use early return in cObj::getImgResource
If ContentObjectRenderer::getImgResource is called without any
data, there is no need to execute all possibilities and lookup
files with an empty identifier.
For instance TextMenuContentObject::getBeforeAfter triggers
this at lot.
Resolves: #66028
Releases: master, 6.2
Change-Id: Iee7a3ce0f2956cd6ddae8c2e3d194f3cf2855c49
Reviewed-on: http://review.typo3.org/38223
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
History
#1
Updated by Gerrit Code Review over 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38162
#2
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38162
#3
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38223
#4
Updated by Oliver Hader over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset e26def8ca3bbcafd15ee40838c3abd6cc45f2934.
#5
Updated by Benni Mack about 1 year ago
- Status changed from Resolved to Closed