Project

General

Profile

Actions

Bug #66616

closed

Double encoding in tag builder

Added by Jan Kiesewetter over 9 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2015-04-28
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The tag builder uses htmlspecialchars to encode values of attributes. The problem is, that if I give in a value from the database containing " it will be double html encoded because htmlspecialchars just called without some parameters.

https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/fluid/Classes/Core/ViewHelper/TagBuilder.php#l174

My suggestion would be

htmlspecialchars($attributeValue, ENT_QUOTES, 'UTF-8', FALSE);

Actions

Also available in: Atom PDF