Task #67248

Clean up DataMapper::convertClassNameToTableName

Added by Mathias Brodala almost 6 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Category:
Code Cleanup
Target version:
Start date:
2015-06-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The source of DataMapper:: currently reads:

public function convertClassNameToTableName($className = NULL) {
  if ($className !== NULL) {
    $tableName = $this->getDataMap($className)->getTableName();
  } else {
    $tableName = strtolower($className);
  }
  return $tableName;
}

This is pointless since every non-NULL value returns the table name from a matching DataMap and every NULL value is processed with strtolower. This should be removed.

It also does not make sense to make the $className parameter optional.

#1

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39900

#2

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39900

#3

Updated by Mathias Brodala almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 50 to 100
#4

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF