Actions
Task #67336
closedEpic #67492: Clean up DataHandler
Introduce early returns in DataHandler
Status:
Closed
Priority:
Should have
Assignee:
Category:
DataHandler aka TCEmain
Target version:
-
Start date:
2015-06-07
Due date:
% Done:
0%
Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:
Description
As discussed on Slack, to ease understanding of DataHandler, we want to introduce early returns, especially into the complex methods that have a lot of different error cases. This might also involve factoring out some methods to get a possibility for an early return.
We should discuss if "early return" also includes continue/break in for-loops, as some of these are also quite complex in DataHandler.
See https://scrutinizer-ci.com/g/TYPO3/TYPO3.CMS/code-structure/master/class/TYPO3%5CCMS%5CCore%5CDataHandling%5CDataHandler for an analysis of the class.
I will publish intermediate results on https://github.com/andreaswolf/TYPO3.CMS/tree/datahandler-cleanup
Actions