Project

General

Profile

Actions

Task #67500

closed

Epic #67492: Clean up DataHandler

Early loop continues in DataHandler::process_*

Added by Andreas Wolf almost 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
DataHandler aka TCEmain
Target version:
Start date:
2015-06-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The methods process_cmdmap and process_datamap are deeply nested, making them hard to comprehend. Using early continues (as a kind of guard clauses) in the foreach-loops will make them easier to read and understand.

Actions #1

Updated by Andreas Wolf almost 9 years ago

  • Parent task set to #67492
Actions #2

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40295

Actions #3

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40311

Actions #4

Updated by Andreas Wolf almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF