Task #67579
closed
Epic #67492: Clean up DataHandler
Remove code duplication in DataHandler::copyRecord_processManyToMany()
100%
Description
(This relies on #67510 being merged, as the method name is introduced there; until that happens, the method name is copyRecord_procBasedOnFieldType())
There is an if-elseif construct in the method that contains 99% duplicated code and two extremely ugly conditions. The duplication should be removed, while simplifying the condition to an understandable level (or documenting it properly).
Updated by Gerrit Code Review about 10 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40423
Updated by Gerrit Code Review about 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40423
Updated by Gerrit Code Review about 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40423
Updated by Gerrit Code Review about 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40423
Updated by Andreas Wolf about 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset ee6fd9f6b8473ebace3d28403b92ed2d88182128.
Updated by Riccardo De Contardi over 7 years ago
- Status changed from Resolved to Closed