Bug #67707

Invalid SQL Query in LanguageIsoCodeUpdate

Added by Morton Jonuschat about 4 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Must have
Category:
Install Tool
Target version:
Start date:
2015-06-23
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

The statement SELECT COUNT FROM "sys_language" WHERE "language_isocode" = "" AND "static_lang_isocode" != "" is invalid as it uses double quotes for field values. Double Quotes should be used for identifiers, single quotes for values.

Associated revisions

Revision 2ec2acb4 (diff)
Added by Morton Jonuschat about 4 years ago

[BUGFIX] Install Tool: Make ISO language SQL queries DBAL compatible

Use database independent quoting for field values and compare the
numeric static_lang_isocode field with an integer instead of an empty
string.

Resolves: #67707
Related: #61542
Releases: master
Change-Id: I7c7e1352e92598a57524a05c9e048391df63df13
Reviewed-on: http://review.typo3.org/40575
Reviewed-by: Markus Klein <>
Reviewed-by: Benjamin Mack <>
Tested-by: Benjamin Mack <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

History

#1 Updated by Morton Jonuschat about 4 years ago

Additionally `static_lang_isocode` is an integer field

#2 Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40575

#3 Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40575

#4 Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40575

#5 Updated by Susanne Moog about 4 years ago

  • Category changed from Install Tool to 1601

#6 Updated by Morton Jonuschat about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF