Feature #67890
closedRedesign FluidTemplateDataProcessorInterface
100%
Description
Currently the method process in FluidTemplateDataProcessorInterface looks like
public function process( array &$data, // $this->cObj->data array $processorConfiguration, array $configuration, StandaloneView $view );
where $data is $this->cObj->data coming from FluidTemplateContentObject.
There are two issues with this:
1) The data processors currently written and in review are instantiating the ContentObjectRenderer ($this->cObj) again. This is overkill, since it is already available in FluidTemplateContentObject.
2) This variable is referenced, which makes it possible to influence $this->cObj->data. It is better to assign manipulated values to the view directly, instead of using $cObj->data. As an example: {data.bullets} should contain the non-manipulated data, {bullets} should contain the manipulated data.
3) The table name is desired in the data processors.
The proposal is to use $this->cObj from FluidTemplateContentObject in the method process of FluidTemplateDataProcessorInterface, like
public function process( array $cObj, // $this->cObj array $processorConfiguration, array $configuration, StandaloneView $view );
This is breaking since we introduced the interface in version 7.3.0
Updated by Gerrit Code Review over 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40915
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40915
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40915
Updated by Gerrit Code Review over 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40915
Updated by Gerrit Code Review over 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40915
Updated by Benni Mack over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset d26b0a5545a74fa417b90af81b3c9d182cb51c0e.
Updated by Gerrit Code Review over 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40950
Updated by Frans Saris over 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset 457f7b051a18ee474b142e3dc6d5277e5242cdeb.