Task #68074

Streamline usage of PageRenderer core-wide

Added by Nicole Cordes over 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Code Cleanup
Target version:
Start date:
2015-07-13
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:
Remote Sprint

Description

As the PageRenderer implements a SingletonInterface, there can only be one instance during runtime. There is no need to get the PageRenderer from other objects, this makes the whole handling unnecessary complicated. We should get rid of public getPageRenderer() functions and streamline the internal handling as best practice.

Associated revisions

Revision 5fd24499 (diff)
Added by Nicole Cordes over 4 years ago

[TASK] Streamline usage of PageRenderer

The PageRenderer is a Singleton and only one instance exists during
runtime. This patch cleans up the usage and prevents sharing the
PageRenderer object over public getters. This helps to improve the api
and get rid of unnecessary functions.

Releases: master
Resolves: #68074
Change-Id: I66abd565df96ff0b8fb31d24a04721ca8ecb3f3a
Reviewed-on: http://review.typo3.org/41131
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Benjamin Mack <>
Tested-by: Benjamin Mack <>

Revision 43ab6508 (diff)
Added by Wouter Wolters over 4 years ago

[FOLLOWUP][TASK] Streamline usage of PageRenderer

Use local variable in FormEngine for PageRenderer,
remove redeclared function in TriggerViewHelper and
solve problem with public getPageRenderer() deprecation.

Releases: master
Resolves: #68074
Change-Id: Ifc7325055189df6c1ff93c308bd8911262d7fe67
Reviewed-on: http://review.typo3.org/41239
Reviewed-by: Nicole Cordes <>
Tested-by: Nicole Cordes <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

History

#1 Updated by Nicole Cordes over 4 years ago

  • Sprint Focus set to Remote Sprint

#2 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41131

#3 Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41131

#4 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41131

#5 Updated by Nicole Cordes over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41239

#7 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41239

#8 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41239

#9 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41239

#10 Updated by Wouter Wolters over 4 years ago

  • Status changed from Under Review to Resolved

#11 Updated by Riccardo De Contardi over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF