Task #68748

Wording: Rename AbstractContentObject->getContentObject() to getContentObjectRenderer()

Added by Elmar Hinz over 6 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2015-08-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
no-brainer
Sprint Focus:

Description

Wording issue: AbstractContentObject->getContentObject() returns a ContentObjectRenderer and not itself.

Hence, the API should be improved. Rename it to AbstractContentObject->getContentObjectRenderer()

#1

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42272

#2

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42272

#3

Updated by Elmar Hinz over 6 years ago

There is a difference between ContentObject and ContentObjectRenderer.

TYPO3\CMS\Frontend\ContentObject\AbstractContentObject
TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer

For historical reasons we are used to address the ContentObjectRenderer as $cObj. However, to improve TYPO3 we need to come to a clean wording step by step.

TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer already demonstrates the clean wording.

A: To come to a clean wording with getContentObject and getContentObjectRenderer in the full range of TYPO3\CMS\Frontend\ it's just 2 places of Code to change:

TYPO3\CMS\Frontend\ContentObject\AbstractContentObject
Tests/Unit/ContentObject/FluidTemplateContentObjectTest

AbstractContentObject->getContentObject isn't called in any other place in the core, than in FluidTemplateContentObjectTest.

B: To come to a clean wording with this in the full range of extbase/fluid it's about 10 places to change. But that is technically independent.

C: On the long run it would be worthy to make the public accessible $cObj variable protected and access the ContentObjectRenderer by getContentRenderer().

#4

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42272

#5

Updated by Benni Mack about 6 years ago

  • Category deleted (1599)
  • Target version deleted (7 LTS)
#6

Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42272

#7

Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42272

#8

Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42272

#9

Updated by Gerrit Code Review almost 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42272

#10

Updated by Gerrit Code Review almost 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42272

#11

Updated by Gerrit Code Review almost 6 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42272

#12

Updated by Gerrit Code Review almost 6 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42272

#13

Updated by Gerrit Code Review almost 6 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42272

#14

Updated by Andreas Wolf almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#15

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF