Project

General

Profile

Actions

Bug #69173

closed

Introduce runtime cache for \TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv()

Added by Markus Klein over 9 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Performance
Target version:
Start date:
2015-08-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:
Remote Sprint

Description

\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv() is called a lot and calls itself recursively as well.

The request to switch from one page to another one in BE (Page module) fires the method more than 1148 times.
According to xdebug profiling this makes up 84ms (63ms owntime).

By introducing a runtime cache the number of calls can be lowered to 162 for the same request, which brings the time metrics below 1ms.

Actions #1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42730

Actions #2

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42732

Actions #3

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42732

Actions #4

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42732

Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42732

Actions #6

Updated by Markus Klein about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF