Bug #69224

Fix wrong usage of Enumerations in InformationStatus::mapStatusToInt()

Added by Sascha Egerer almost 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend User Interface
Target version:
Start date:
2015-08-21
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Stabilization Sprint

Description

The InformationStatus Enumeration provides a mapStatusToInt() method. The method expects a string but should expect an enum of itself.

Associated revisions

Revision 822d1e84 (diff)
Added by Sascha Egerer almost 4 years ago

[!!!][BUGFIX] Fix wrong usage of Enum in InformationStatus Enum itself

The Enumeration implementation of InformationStatus provides
a mapStatusToInt() method that must expect a InformationStatus instance
as parameter instead of a string.

The method mapStatusToInt() has also been replaced by "isGreaterThan" as
a comparison method fits better into the enumeration usage.

This change is breaking but should not really break anything as it
was introduced in 7.4 and only used at one place in the core.

Change-Id: I84548ba291360d1b20a607fa1e5149b95ca93bda
Resolves: #69224
Releases: master
Reviewed-on: http://review.typo3.org/42804
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Sascha Egerer <>
Tested-by: Sascha Egerer <>

History

#1 Updated by Gerrit Code Review almost 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42804

#2 Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42804

#3 Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42804

#4 Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42804

#5 Updated by Gerrit Code Review almost 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42804

#6 Updated by Mathias Schreiber almost 4 years ago

  • Sprint Focus changed from Remote Sprint to Stabilization Sprint

#7 Updated by Gerrit Code Review almost 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42804

#8 Updated by Gerrit Code Review almost 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42804

#9 Updated by Sascha Egerer almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Riccardo De Contardi over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF