Task #69416

make AbstractPlugin::pi_loadLL load labels from custom file

Added by Tymoteusz Motylewski over 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2015-08-30
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Right now AbstractPlugin::pi_loadLL looks for hardcoded
language.xml file in the scirpt directory "scriptRelPath".

'EXT:' . $this->extKey . '/' . dirname($this->scriptRelPath) . '/locallang.xlf';

This doesn't allow to use Extbase like structure for pi-based extensions (placing language lables in Resources/Private/Language

In few places in the core, we still keep scriptRelPath containing wrong value (script location and name has already changed during namespace change). And the only reason for it is that we need this property for loading language files.

The solution would be to make AbstractPlugin::pi_loadLL take an optional argument pointing to the correct loaction of the language file.

Associated revisions

Revision 4dd593e4 (diff)
Added by Tymoteusz Motylewski over 4 years ago

[FEATURE] Allow AbstractPlugin::pi_loadLL to load custom language file

Add optional parameter to pi_loadlLL method to allow loading
language files located somewhere else than $this->scriptRelPath folder.
This change allows to place language files in Resources/Private/Language
also in pi-based plugins.

Resolves: #69416
Releases: master
Change-Id: Ibcfef65b1606a86559f17e706f8873a2c5a3973b
Reviewed-on: http://review.typo3.org/42934
Reviewed-by: Alexander Opitz <>
Tested-by: Alexander Opitz <>
Reviewed-by: Xavier Perseguers <>
Tested-by: Xavier Perseguers <>

History

#1 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42934

#2 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42934

#3 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42934

#4 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42934

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42934

#6 Updated by Gerrit Code Review over 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42934

#7 Updated by Tymoteusz Motylewski over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF