Bug #70272: requestUpdate on select field using rendermode=tree causes javascript error - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #70272

closed

requestUpdate on select field using rendermode=tree causes javascript error

Added by Philipp Wrann about 9 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

FormEngine aka TCEforms

Target version:

7 LTS

Start date:

2015-10-01

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

5.6

Tags:

Complexity:

Is Regression:

Sprint Focus:

Remote Sprint

Description

If you define a select field as renderMode=Tree and set the field as "requestUpdate" field, a javascript error will break everything because the printed string has unescaped double quotes.

The problem is located in SelectTreeElement::render in line 136 (see screensot)

Suggestion wrap the $onChange variable in addslashes before concatenating the html-string.

Files

tca-tree-onchange.png (95.4 KB) tca-tree-onchange.png

Philipp Wrann, 2015-10-01 15:55

Actions

Copy link

Updated by Philipp Wrann about 9 years ago

Can someone update the title?

requestUpdate on select field using rendermode=tree causes javascript error

Dont know how i came up with that title xD

Actions

Copy link

Updated by Philipp Wrann about 9 years ago

File tca-tree-onchange.png tca-tree-onchange.png added

Forgot the screenshot

Actions

Copy link

Updated by Andreas Kienast about 9 years ago

Subject changed from RequestUpdate in causes javascript error in Tree to requestUpdate on select field using rendermode=tree causes javascript error

Actions

Copy link

Updated by Andreas Kienast about 9 years ago

Status changed from New to In Progress
Sprint Focus set to Remote Sprint

Actions

Copy link

Updated by Andreas Kienast about 9 years ago

Target version changed from next-patchlevel to 7 LTS

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43697

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43697

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43697

Actions

Copy link

Updated by Gerrit Code Review about 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43697

Actions

Copy link

#10