Project

General

Profile

Actions

Bug #70697

closed

Possible silent fatal error with legacy extensions

Added by Xavier Perseguers over 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Category:
Extension Manager
Target version:
Start date:
2015-10-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Remote Sprint

Description

Step to reproduce

  • Ensure EXT:compatibility6 is not loaded
  • Have an extension coming with an update script @class.ext_update.php` like that:
class ext_update extends t3lib_SCbase {
    // ...
}
  • Open Extension Manager

This results into a white screen without any error nor log entry.

Actions #1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/44059

Actions #2

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/44059

Actions #3

Updated by Xavier Perseguers over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Xavier Perseguers over 8 years ago

Fix for TYPO3 6.2:

diff --git a/typo3/sysext/extensionmanager/Classes/Utility/UpdateScriptUtility.php b/typo3/sysext/extensionmanager/Classes/Utility/UpdateScriptUtility.php
index 9766ee6..0ee2213 100644
--- a/typo3/sysext/extensionmanager/Classes/Utility/UpdateScriptUtility.php
+++ b/typo3/sysext/extensionmanager/Classes/Utility/UpdateScriptUtility.php
@@ -115,7 +115,7 @@ class UpdateScriptUtility {
         } else {
             $className = $matches[1] . '\ext_update';
         }
-        @include_once $updateScript;
+        include_once $updateScript;
         if (!class_exists($className, FALSE)) {
             throw new ExtensionManagerException(
                 sprintf('class.ext_update.php of extension "%s" did not declare ext_update class', $extensionKey),
Actions #5

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/44120

Actions #6

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/44120

Actions #7

Updated by Xavier Perseguers over 8 years ago

  • Status changed from Under Review to Resolved
Actions #8

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF