Project

General

Profile

Actions

Bug #70864

closed

Missing space after colon in Extension Manager

Added by Xavier Perseguers about 9 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
Start date:
2015-10-20
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
hard
Is Regression:
Yes
Sprint Focus:
Remote Sprint

Description

Although still present in former versions of TYPO3, this tiny little bug should be fixed for 7.

Problem

In EM, the colon for configuration setting's label is used to separate the "title" from the "description" of the setting.

However the split is wrongly done and the label is trim-split more than into 2 elements, before being recombined.

Having a label such as

<trans-unit id="settings.tika_jar_path">
    <source>Tika Application Path: Path to your Apache Tika application jar file (tika-app-x.x.jar). This
        path may be relative to the root of your website or absolute. Download the jar from:
        https://tika.apache.org/download.html
    </source>
</trans-unit>

results into that being displayed (for the description):


Files

nospace.png (12.3 KB) nospace.png Xavier Perseguers, 2015-10-20 10:55

Related issues 1 (1 open0 closed)

Related to TYPO3 Core - Bug #70867: Use or lack of xml:space="preserve" is not respectedNew2015-10-20

Actions
Actions #1

Updated by Xavier Perseguers about 9 years ago

  • Category deleted (Extension Manager)
  • Complexity set to hard
  • Is Regression changed from No to Yes

Oups! Actually this bug comes from GeneralUtility:trimExplode() since the corresponding code in EM is:

$configurationOption['label'] = $this->translate($configurationOption['label'], $extensionKey);
$configurationOption['labels'] = GeneralUtility::trimExplode(':', $configurationOption['label'], false, 2);
Actions #2

Updated by Gerrit Code Review about 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44178

Actions #3

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44178

Actions #4

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44178

Actions #5

Updated by Gerrit Code Review about 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44194

Actions #6

Updated by Xavier Perseguers about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF