Project

General

Profile

Actions

Feature #71703

closed

Introduce ATagParams addGlobal TypoScript configuration

Added by Kevin Ditscheid about 9 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Could have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2015-11-19
Due date:
% Done:

100%

Estimated time:
PHP Version:
5.5
Tags:
ATagParams typolink
Complexity:
Sprint Focus:

Description

Hey guys,

I'm falling accross some issues with typolink ATagParams right now.
I added a tabindex via
config.ATagParams = tabindex="20"
to enable tabindex for all rendered links.
Obviously, not all links, generated by TypoScript, should have the same tabindex, so i defined typolink.ATagParams = tabindex="1" for a home link, for example. Unfortunately, the typoscript.ATagParams option did not behave like i expected it to. It doesn't replace the global config.ATagParams option, but prepends the new tabindex="1" to the global tabindex="20". Now I understood, that the ATagParams will not be parsed and split to its single params, so I searched for a way, to disable the global config.ATagParams option for this specific typolink, but the TypoScript configuration for typolink does not provide such an option. I took a look into the ContentObjectRenderer and the method getATagParams does indeed provide a parameter $addGlobal, to disable the global option, but in method typoLink, the parameter is unused. It would be great to disable this global option for single typolinks, via an option like this:
typolink{
ATagParams = tabindex="1"
doNotAppendGlobalATagParams = 1
}

Actions #1

Updated by Susanne Moog about 7 years ago

  • Category changed from Content Rendering to Frontend
Actions #2

Updated by Benni Mack almost 3 years ago

Hey Kevin,

thank you for your report.

I checked this in v11. If you have a global option config.ATagParams = tabindex="20" and you override the tabindex in your local config, the tabindex will be used from your local links, and the duplicates are resolved. the local link takes precedence.

I will however add tests for this to show that this works.

Actions #3

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72895

Actions #4

Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72896

Actions #5

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72896

Actions #6

Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72915

Actions #7

Updated by Benni Mack almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF