Project

General

Profile

Actions

Bug #72038

closed

Missing $name in TYPO3\CMS\Core\Page\PageRenderer::addCssLibrary()

Added by Bill Dagou almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Won't have this time
Assignee:
-
Category:
-
Target version:
-
Start date:
2015-12-03
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

First of all, I'm not sure whether it's a bug or not. But according to addJsLibrary() and addJsFooterLibrary(), I think the index for $cssLibs should be something like strtolower($name) rather than $file. Right now, addCssLibrary() is much like addCssFile().

Actions #1

Updated by Markus Klein almost 9 years ago

  • Status changed from New to Needs Feedback

What is your problem, and what does not work?

Actions #2

Updated by Bill Dagou almost 9 years ago

Sometimes, I use

$GLOBALS['TSFE']->getPageRenderer()->addCssLibrary('some.css');

in my code to include some.css in <head>, and may replace it by another.css in a hook.

What I expected is, addCssLibrary() could use a $name to identify the .css included, like what addJsLibrary() or addJsFooterLibrary() does, so

$GLOBALS['TSFE']->getPageRenderer()->addCssLibrary('css', 'some.css');
...
$GLOBALS['TSFE']->getPageRenderer()->addCssLibrary('css', 'another.css');

will only include another.css rather than both.

Actions #3

Updated by Bill Dagou almost 9 years ago

Never mind, I will take care of what I need in my code if it involves a lot, and you can ignore this issue and close it.

Thanks again for the whole TYPO3 team.

Actions #4

Updated by Georg Ringer almost 9 years ago

  • Status changed from Needs Feedback to Closed
  • Priority changed from Could have to Won't have this time

I will close this issue as requested. even though it would be nice to have more calls of the API look like the same, it would require a lot of deprecations to get this into a nicer shape. it would be more likely to restructure the whole class.

still thanks a lot for reporting the idea!

Actions

Also available in: Atom PDF