Bug #72183

ConfigureExtensionViewHelper::render() has incompatible method signature

Added by Morton Jonuschat over 6 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Should have
Category:
Extension Manager
Target version:
Start date:
2015-12-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Declaration of TYPO3\CMS\Extensionmanager\ViewHelpers\ConfigureExtensionViewHelper::render($extension, $forceConfiguration = true, $showDescription = false) should be compatible with TYPO3\CMS\Fluid\ViewHelpers\Link\ActionViewHelper::render($action = NULL, array $arguments = Array, $controller = NULL, $extensionName = NULL, $pluginName = NULL, $pageUid = NULL, $pageType = 0, $noCache = false, $noCacheHash = false, $section = '', $format = '', $linkAccessRestrictedPages = false, array $additionalParams = Array, $absolute = false, $addQueryString = false, array $argumentsToBeExcludedFromQueryString = Array, $addQueryStringMethod = NULL)

#1

Updated by Morton Jonuschat over 6 years ago

  • Status changed from New to In Progress
  • Assignee set to Morton Jonuschat
  • Target version changed from Candidate for patchlevel to 7.6.1
#2

Updated by Gerrit Code Review over 6 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45217

#3

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45217

#4

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45217

#5

Updated by Claus Due over 6 years ago

On a side note, there are some very good reasons to use `initializeArguments┬┤ instead of render method arguments:

  • You avoid situations like this one (is php7 safe)
  • You can override some or all arguments and add new ones
  • You can opt to NOT register all arguments of the parent
  • It avoids reflection completely and does not impose requirements on phpdoc
  • It allows passing `$this->arguments` directly to `renderStatic`

In my honest opinion, support for render method arguments should have never been added. It would be worth while to get rid of them...

#6

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45217

#7

Updated by Morton Jonuschat over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#8

Updated by Riccardo De Contardi almost 5 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF