Bug #72183
closed
ConfigureExtensionViewHelper::render() has incompatible method signature
100%
Description
Declaration of TYPO3\CMS\Extensionmanager\ViewHelpers\ConfigureExtensionViewHelper::render($extension, $forceConfiguration = true, $showDescription = false) should be compatible with TYPO3\CMS\Fluid\ViewHelpers\Link\ActionViewHelper::render($action = NULL, array $arguments = Array, $controller = NULL, $extensionName = NULL, $pluginName = NULL, $pageUid = NULL, $pageType = 0, $noCache = false, $noCacheHash = false, $section = '', $format = '', $linkAccessRestrictedPages = false, array $additionalParams = Array, $absolute = false, $addQueryString = false, array $argumentsToBeExcludedFromQueryString = Array, $addQueryStringMethod = NULL)
Updated by Morton Jonuschat almost 9 years ago
- Status changed from New to In Progress
- Assignee set to Morton Jonuschat
- Target version changed from Candidate for patchlevel to 7.6.1
Updated by Gerrit Code Review almost 9 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45217
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45217
Updated by Gerrit Code Review almost 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45217
Updated by Claus Due almost 9 years ago
On a side note, there are some very good reasons to use `initializeArguments´ instead of render method arguments:
- You avoid situations like this one (is php7 safe)
- You can override some or all arguments and add new ones
- You can opt to NOT register all arguments of the parent
- It avoids reflection completely and does not impose requirements on phpdoc
- It allows passing `$this->arguments` directly to `renderStatic`
In my honest opinion, support for render method arguments should have never been added. It would be worth while to get rid of them...
Updated by Gerrit Code Review almost 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45217
Updated by Morton Jonuschat almost 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 381b047302c3e24b6f217b117e5710c3a9eb51c9.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed