Project

General

Profile

Actions

Task #72485

closed

Optimize FormEngineValidation, part 1

Added by Andreas Kienast almost 9 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Category:
FormEngine aka TCEforms
Target version:
Start date:
2015-12-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:
Remote Sprint

Description

The current implementation of FormEngineValidation has some performance flaws: Some evaluation commands check each character of the passed value instead of applying regular expressions. Also, some custom methods can be replaced by native JavaScript.


Related issues 1 (0 open1 closed)

Precedes TYPO3 Core - Bug #83731: JavaScript error when using 'eval' => 'int,nospace' in TCAClosedStephan Großberndt2015-12-312015-12-31

Actions
Actions #1

Updated by Andreas Kienast almost 9 years ago

  • Description updated (diff)
Actions #2

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from New to Under Review

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45348

Actions #3

Updated by Gerrit Code Review almost 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45348

Actions #4

Updated by Gerrit Code Review almost 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45348

Actions #5

Updated by Gerrit Code Review almost 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45348

Actions #6

Updated by Andreas Fernandez almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions #8

Updated by Stephan Großberndt almost 7 years ago

  • Precedes Bug #83731: JavaScript error when using 'eval' => 'int,nospace' in TCA added
Actions

Also available in: Atom PDF