Project

General

Profile

Actions

Bug #72635

closed

SimpleFileBackend::setCacheDirectory returns invalid path names if cache is located outside typo3temp

Added by Jan Helke about 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Caching
Target version:
Start date:
2016-01-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The comment for the method \TYPO3\CMS\Core\Cache\Backend\SimpleFileBackend::setCacheDirectory() states clearly, that it is possible to provide an absolute path as cache directory. However, in the lower part of the function, it is stated, that if ($cacheDirectory0 == '/') the documentRoot should be set to '/'. That results in a returned path like '//...'.
This causes problems within \TYPO3\CMS\Core\Utility\GeneralUtility::validPathStr(), because pathes with '//' in it are always invalid.
So my suggestion would be to set the documentRoot to '' if the condition is true.

Actions #1

Updated by Gerrit Code Review about 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46148

Actions #2

Updated by Gerrit Code Review about 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46148

Actions #3

Updated by Gerrit Code Review about 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46148

Actions #4

Updated by Gerrit Code Review about 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46148

Actions #5

Updated by Gerrit Code Review about 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46148

Actions #6

Updated by Gerrit Code Review about 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46157

Actions #7

Updated by Jan Helke about 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Gerrit Code Review about 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46158

Actions #9

Updated by Jan Helke about 8 years ago

  • Status changed from Under Review to Resolved
Actions #10

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF