Bug #72635
closed
SimpleFileBackend::setCacheDirectory returns invalid path names if cache is located outside typo3temp
100%
Description
The comment for the method \TYPO3\CMS\Core\Cache\Backend\SimpleFileBackend::setCacheDirectory() states clearly, that it is possible to provide an absolute path as cache directory. However, in the lower part of the function, it is stated, that if ($cacheDirectory0 == '/') the documentRoot should be set to '/'. That results in a returned path like '//...'.
This causes problems within \TYPO3\CMS\Core\Utility\GeneralUtility::validPathStr(), because pathes with '//' in it are always invalid.
So my suggestion would be to set the documentRoot to '' if the condition is true.
Updated by Gerrit Code Review almost 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46148
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46148
Updated by Gerrit Code Review almost 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46148
Updated by Gerrit Code Review almost 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46148
Updated by Gerrit Code Review almost 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46148
Updated by Gerrit Code Review almost 9 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46157
Updated by Jan Helke almost 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b74bd367809083a6c582beeef64de1dd162bb99c.
Updated by Gerrit Code Review almost 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46158
Updated by Jan Helke almost 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset 344e1484eb51bfab2da1199df3f0310e13595772.
Updated by