Bug #72752

FormengineUtility::getIconHtml throws warning if file is missing

Added by Tymoteusz Motylewski over 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2016-01-15
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

getIconHtml method of the FormEngineUtility throws a warning if it is fed with non existing file path like

EXT:t3skin/icons/gfx/i/tt_content_header.gif

(this file was removed recently in https://review.typo3.org/#/c/45943/ )

Associated revisions

Revision 1c1cebe1 (diff)
Added by Tymoteusz Motylewski over 3 years ago

[BUGFIX] Do not throw warning in FormEngineUtility::getIconHtml

Feeding getIconHtml with non existing file path
is not throwing a warning now.

Releases: 7.6, master
Resolves: #72752
Change-Id: Ic11d6a5551ec964d4f94f2dc3f9542157985f72a
Reviewed-on: https://review.typo3.org/45978
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Morton Jonuschat <>
Tested-by: Morton Jonuschat <>

Revision e4b419c1 (diff)
Added by Tymoteusz Motylewski over 3 years ago

[BUGFIX] Do not throw warning in FormEngineUtility::getIconHtml

Feeding getIconHtml with non existing file path
is not throwing a warning now.

Releases: 7.6, master
Resolves: #72752
Change-Id: Ic11d6a5551ec964d4f94f2dc3f9542157985f72a
Reviewed-on: https://review.typo3.org/45978
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
(cherry picked from commit 1c1cebe149d6c5d7586350357c3784bf638da31e)
Reviewed-on: https://review.typo3.org/45979

History

#1 Updated by Tymoteusz Motylewski over 3 years ago

It can be tested with current bootstrap package and v8. Just try to add new content element.
As bootstrap package has something like:

array(
        'LLL:EXT:bootstrap_package/Resources/Private/Language/Backend.xlf:content_element.texticon',
        'bootstrap_package_texticon',
        'i/tt_content_header.gif'
    ),

#2 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45978

#3 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45979

#4 Updated by Tymoteusz Motylewski over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF