Bug #72926
closedIconFactory getIconForRecord might not produce correct icon in ajax (inline) context
100%
Description
IconFactory uses IconRegistry isRegisterd method in mapRecordTypeToIconIdentifier to determine correct record icon.
This might fail to determine the correct icon as IconRegistry is Singleton and only initializes TCA icons in constructor (if TCA is already set) or in getIconConfigurationByIdentufier.
However, getIconConfigurationByIdentufier happens after the isRegistered checks in mapRecordTypeToIconIdentifier.
To ensure it will also work correctly in various extensions, it might be best to do the initialize checks in all methods in IconRegistry as e.g. getAllRegisteredIconIdentifiers should also include TCA icons, if they weren't initialized prior.
Updated by Gerrit Code Review over 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46226
Updated by Gerrit Code Review over 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46226
Updated by Gerrit Code Review over 8 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46226
Updated by Frank Nägler over 8 years ago
- Target version changed from Candidate for patchlevel to 7.6.3
Updated by Gerrit Code Review over 8 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46226
Updated by Gerrit Code Review over 8 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46226
Updated by Gerrit Code Review over 8 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46306
Updated by Frank Nägler over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 528cf702f2524736606ef1277603fca54af1b9d4.
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from Resolved to Closed