Project

General

Profile

Actions

Bug #72926

closed

IconFactory getIconForRecord might not produce correct icon in ajax (inline) context

Added by Andreas Allacher over 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Backend API
Target version:
Start date:
2016-01-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

IconFactory uses IconRegistry isRegisterd method in mapRecordTypeToIconIdentifier to determine correct record icon.
This might fail to determine the correct icon as IconRegistry is Singleton and only initializes TCA icons in constructor (if TCA is already set) or in getIconConfigurationByIdentufier.

However, getIconConfigurationByIdentufier happens after the isRegistered checks in mapRecordTypeToIconIdentifier.

To ensure it will also work correctly in various extensions, it might be best to do the initialize checks in all methods in IconRegistry as e.g. getAllRegisteredIconIdentifiers should also include TCA icons, if they weren't initialized prior.

Actions #1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46226

Actions #2

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46226

Actions #3

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46226

Actions #4

Updated by Frank Nägler over 8 years ago

  • Target version changed from Candidate for patchlevel to 7.6.3
Actions #5

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46226

Actions #6

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46226

Actions #7

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46306

Actions #8

Updated by Frank Nägler over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF