Project

General

Profile

Actions

Bug #73103

closed

Off-by-one error in FAL

Added by Andreas Kienast about 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Start date:
2016-02-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The filelist has an off-by-one issue while using the page browser.

How to reproduce

Create a new folder in fileadmin and create 100 empty test files: for i in {0..100}; do touch $i.txt; done;
The list goes from 0.txt to 39.txt. After switching to the next page, the result list goes from 39.txt to 78.txt, missing 79.txt. Switching to the next page again renders the list from 79.txt to 99.txt and so on.

I think the issue is related to the LocalDriver, which changes the starting point by one:

// ./typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php +371
if ($start > 0) {
    $start--;
}

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #69390: File not displayed on second page in filelistClosedBenni Mack2015-08-28

Actions
Actions #1

Updated by Gerrit Code Review about 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46461

Actions #2

Updated by Gerrit Code Review about 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46461

Actions #3

Updated by Gerrit Code Review about 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46501

Actions #4

Updated by Andreas Fernandez about 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Gerrit Code Review about 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46502

Actions #6

Updated by Andreas Fernandez about 8 years ago

  • Status changed from Under Review to Resolved
Actions #7

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF