Bug #73237

More failing Unit Tests on Windows Systems

Added by Nicole Cordes over 4 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
Start date:
2016-02-11
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Still 2 Unit Tests are failing on Windows System after applying patch for issue #73006

There were 2 failures:

1) TYPO3\CMS\Fluid\Tests\Unit\Core\Cache\FluidTemplateCacheTest::setCallsSetOnBackend
Expectation failed for method name is equal to <string:set> when invoked 1 time(s)
Parameter 1 for invocation TYPO3\CMS\Core\Cache\Backend\BackendInterface::set('test', 'Failed asserting that two strings are equal.
--- Expected
+++ Actual
@ @
' test
#'

D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Classes\Cache\Frontend\PhpFrontend.php:65
D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\fluid\Classes\Core\Cache\FluidTemplateCache.php:61
D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\fluid\Tests\Unit\Core\Cache\FluidTemplateCacheTest.php:59
D:\Version Control\Git\TYPO3\TYPO3.CMS\master\vendor\phpunit\phpunit\phpunit:47

2) TYPO3\CMS\Fluid\Tests\Unit\Core\Cache\FluidTemplateCacheTest::setRemovesLeadingPhpTagBeforeCallingParentWhichAddsLeadingPhpTag
Expectation failed for method name is equal to <string:set> when invoked 1 time(s)
Parameter 1 for invocation TYPO3\CMS\Core\Cache\Backend\BackendInterface::set('test', 'Failed asserting that two strings are equal.
--- Expected
++ Actual
@ @
'

test
#'

D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Classes\Cache\Frontend\PhpFrontend.php:65
D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\fluid\Classes\Core\Cache\FluidTemplateCache.php:61
D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\fluid\Tests\Unit\Core\Cache\FluidTemplateCacheTest.php:75
D:\Version Control\Git\TYPO3\TYPO3.CMS\master\vendor\phpunit\phpunit\phpunit:47

Associated revisions

Revision 9d08dae9 (diff)
Added by Nicole Cordes over 4 years ago

[BUGFIX] Ensure correct line ending in fluid Unit Tests

As the TYPO3\CMS\Core\Cache\Frontend\PhpFrontend uses the constant LF
for its data storing the Unit Tests in
TYPO3\CMS\Fluid\Tests\Unit\Core\Cache\FluidTemplateCacheTest have to use
the same constant for comparison.

Resolves: #73237
Releases: master
Change-Id: I2e66ec7726124746a0156d15d4bb462793176d97
Reviewed-on: https://review.typo3.org/46591
Reviewed-by: Daniel Goerz <>
Reviewed-by: Xavier Perseguers <>
Reviewed-by: Morton Jonuschat <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Daniel Maier <>
Tested-by: Daniel Maier <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

History

#1 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46591

#2 Updated by Nicole Cordes over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Riccardo De Contardi about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF