Project

General

Profile

Actions

Bug #73484

closed

VimeoRenderer.php condition always true (autoplay in config)

Added by Daniel Gorges about 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2016-02-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The Vimeorenderer checks if

if ($autoplay !== null) {
                $options['autoplay'] = $autoplay;
            }

But in $autoplay there is always a value. That´s why an autoplay function cannot be set via fluid, as shown in the example (<f:media file="{file}" width="400" height="375" additionalConfig="{autoplay: '1'}" />).

Solution:

if (!empty($autoplay)) {
                $options['autoplay'] = $autoplay;
            }


Files

videorenderer.diff (1.27 KB) videorenderer.diff Daniel Gorges, 2016-02-16 14:18
Actions #1

Updated by Daniel Gorges about 8 years ago

This Problem is also in the YouTubeRenderer.php

Actions #2

Updated by Gerrit Code Review about 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46712

Actions #3

Updated by Steffen Gebert about 8 years ago

  • Project changed from 1575 to TYPO3 Core
  • TYPO3 Version set to 8
  • Is Regression set to No
Actions #4

Updated by Gerrit Code Review about 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46712

Actions #5

Updated by Gerrit Code Review about 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46712

Actions #6

Updated by Gerrit Code Review about 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46976

Actions #7

Updated by Benni Mack about 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF