Bug #73553

Impossible to restore elements from recycler

Added by Jérémie Roulin almost 3 years ago. Updated about 2 months ago.

Status:
Closed
Priority:
Must have
Category:
Recycler
Target version:
Start date:
2016-02-19
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:
Remote Sprint

Description

Hi there,

Since TYPO3 7.6.3 release it is no more possible to restore elements once they have been deleted.

Can anyone tell me why? :)

Kind regards,

Jérémie


Related issues

Related to TYPO3 Recycler - Bug #70863: Recycler doesn't show deleted pages in Typo3 6.2.15 for editors Under Review 2015-10-20

Associated revisions

Revision 626d3ad9 (diff)
Added by Andreas Fernandez over 2 years ago

[BUGFIX] Add missing method getPidOfUid to RecyclerUtility

The backport of #70863 requires the method ``RecyclerUtility:: getPidOfUid()``
introduced with an earlier feature for TYPO3 v8 is missed for the released
7.6 branch. This patch backports the method to TYPO3 CMS 7.6.

Change-Id: I393b663633b680ee8ab5cbfd705c098ebbfa550c
Resolves: #73553
Related: #70863
Releases: 7.6
Reviewed-on: https://review.typo3.org/46795
Reviewed-by: Stephan Großberndt <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>
Reviewed-by: Morton Jonuschat <>
Tested-by: Morton Jonuschat <>

History

#1 Updated by Thomas Kieslich almost 3 years ago

I see:
Fatal error: Call to undefined method TYPO3\CMS\Recycler\Utility\RecyclerUtility::getPidOfUid() in /Users/thomask/Aktuell/www-mamp/projects/ccp/typo3-sources/typo3_src-7.6.3/typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php on line 339

some things changed in this files January, but i cant find a solution.

Update:
the getPidOfUid in RecyclerUtility.php was included on 14.01. but it is not included in TYPO3 7.6.3
changes in DeletedRecords.php on 14.01. to but included in TYPO3 7.6.3

quick fix: i take the complete recycler from todays git master and so far i see it works with recursive restore to.

#2 Updated by Robert Breithuber over 2 years ago

i can also confirm that the Recycler is broken in 7.6.3 :(

to fix it, you can also add the function to sysext/recycler/Classes/Utility/RecyclerUtility.php:

...

/**
 * Helper class for the 'recycler' extension.
 */
class RecyclerUtility
{
    /**
     * Get pid of uid
     *
     * @param int $uid
     * @param string $table
     * @return int
     */
    public static function getPidOfUid($uid, $table)
    {
        $db = static::getDatabaseConnection();
        $res = $db->exec_SELECTquery('pid', $table, 'uid=' . (int)$uid);
        if ($res !== false) {
            $record = $db->sql_fetch_assoc($res);
            return $record['pid'];
        }
        return 0;
    }

...

#3 Updated by Andreas Fernandez over 2 years ago

  • Category set to Recycler
  • Status changed from New to Accepted
  • Assignee set to Andreas Fernandez
  • Is Regression changed from No to Yes
  • Sprint Focus set to Remote Sprint

#4 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46795

#5 Updated by Andreas Fernandez over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF