Bug #73754
closedLocalDriver sorting bug if multiple file with same timestamp
100%
Description
Hi,
I found a bug in the typo3_src-7.6.4/typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php.
I use the function retrieveFileAndFoldersInPath() to recursively list file in a Folder. This list is sort by timestamp.
In the function sortDirectoryEntries() we create an array with timestamp=>File.
At the end of this function we do this:
$i = 0; while (isset($entriesToSort[$sortingKey . $i])) { $i++; } $entriesToSort[intval($sortingKey . $i)] = $entryArray;
I think the developper implement this to avoid duplicate key, in my case, duplicate timestamp.
So the while() add an extra value to the timestamp. But when you have more than 10 files with the same timestamp, you have a number bigger than before.
- I have a 9 files wit the timestamp 1355300542.
- If i have another file with the same timestamp the key will be 135530054210.
To process a sorting on number with strnatcasecmp(), this is a big issue and the list return is not the good one.
This bug happen for sorting file by timesamp and size.
Updated by Yohann CERDAN over 8 years ago
Sorry i add intval() in $entriesToSort[intval($sortingKey . $i)] = $entryArray;
for testing purpose.
Updated by Riccardo De Contardi over 8 years ago
- Status changed from New to Needs Feedback
@Yohann: can you tell us if your problem has been solved? Thank you!
Updated by Yohann CERDAN over 8 years ago
Hi, no it doesnt have a "simple" solution. The method to sort the files have to be rewritten because using key can provide some bugs.
Updated by Riccardo De Contardi over 8 years ago
- Target version changed from 7.6.3 to Candidate for patchlevel
Updated by Riccardo De Contardi over 8 years ago
- Status changed from Needs Feedback to New
Updated by Gerrit Code Review about 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48405
Updated by Gerrit Code Review about 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48405
Updated by Gerrit Code Review about 8 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48405
Updated by Frank Nägler about 8 years ago
- Target version changed from Candidate for patchlevel to 8.2
- Sprint Focus set to Stabilization Sprint
Updated by Gerrit Code Review about 8 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48405
Updated by Gerrit Code Review about 8 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48443
Updated by Frank Nägler about 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset c6847d9f0a2ad34178d6feacda820ad930a67031.
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from Resolved to Closed