Project

General

Profile

Actions

Bug #74536

closed

AjaxWidget broken

Added by Alexander Jahn almost 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Fluid
Target version:
Start date:
2016-03-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Yes
Sprint Focus:

Description

Due to two colliding injects in WidgetRequestHandler the AjaxWidget functionality is completely broken.

After #73018 there are two injects setting requestBuilder within WidgetRequestHandler.

    /**
     * @param \TYPO3\CMS\Extbase\Mvc\Web\RequestBuilder $requestBuilder
     */
    public function injectWidgetRequestBuilder(\TYPO3\CMS\Fluid\Core\Widget\WidgetRequestBuilder $requestBuilder)
    {
        $this->requestBuilder = $requestBuilder;
    }
    /**
     * @param \TYPO3\CMS\Extbase\Mvc\Web\RequestBuilder $requestBuilder
     */
    public function injectRequestBuilder(\TYPO3\CMS\Extbase\Mvc\Web\RequestBuilder $requestBuilder)
    {
        $this->requestBuilder = $requestBuilder;
    }

First the local function "injectWidgetRequestBuilder()" is called and after that the inherited function "injectRequestBuilder()" is called.
Naturally, the inherited function resets the requestBuilder to something that cannot handle a widgetRequest, thus breaking Ajax Autocomplete in fluid.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #73018: Remove @inject from ext:fluidClosedWouter Wolters2016-01-29

Actions
Actions #1

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47163

Actions #2

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47163

Actions #3

Updated by Gerrit Code Review almost 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47163

Actions #4

Updated by Gerrit Code Review almost 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47163

Actions #5

Updated by Markus Gerdes almost 8 years ago

Seems to work here on 7.6.

Actions #6

Updated by Gerrit Code Review almost 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47163

Actions #7

Updated by Gerrit Code Review almost 8 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47163

Actions #8

Updated by Gerrit Code Review almost 8 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47163

Actions #9

Updated by Alexander Jahn almost 8 years ago

  • Status changed from Under Review to Resolved
Actions #10

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47325

Actions #11

Updated by Alexander Jahn almost 8 years ago

  • Status changed from Under Review to Resolved
Actions #12

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF