Actions
Task #75333
closedFSC "bullets" - select bullets type using partials and not f:switch
Start date:
2016-03-31
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
7
PHP Version:
5.5
Tags:
Complexity:
Sprint Focus:
Stabilization Sprint
Description
I've noticed that on sysext/fluid_styled_content/Resources/Private/Templates/Bullets.html the various bullets types are chosen using an <f.switch>.
I am wondering if it could be better to use the same system used for Menu, that is using the values of the field "bullets_type" to select different partials, this way:
the template would become:
<f:section name="content"> <f:render partial="Bullets/Type-{data.bullets_type}" arguments="{_all}" /> </f:section>
and then Type-0.html, Type-1.html and Type-2.html partials must be created.
I hope it is clear enough.
Thank you.
Updated by Frank Nägler over 8 years ago
- Status changed from New to In Progress
- Assignee changed from Gianluigi Martino to Frank Nägler
Updated by Gerrit Code Review over 8 years ago
- Status changed from In Progress to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48407
Updated by Gerrit Code Review over 8 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48407
Updated by Frank Nägler over 8 years ago
- Target version changed from Candidate for patchlevel to 8.2
- Sprint Focus set to Stabilization Sprint
Updated by Frank Nägler over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 8f6830d9d447f09aea7bee6ef092703c9626e0fd.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed
Actions