Project

General

Profile

Actions

Task #75388

closed

Clean up skipped tests on Windows

Added by Susanne Moog over 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Tests
Target version:
-
Start date:
2016-04-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

At the moment a lot of tests are skipped on windows environments. The main reasons are permissions, symlinks and shell exec commands. As symlinks are now working on Windows (if the user / group is allowed to create them, see http://superuser.com/questions/104845/permission-to-make-symbolic-links-in-windows-7) there is no reason to skip those tests. As you can only create valid symlinks on Windows (the target is checked for existence) the tests needed to be adjusted to take that into account.

Additionally some of the other tests don't need to be skipped either, as they mock all system specific calls (e.g. AbstractNodeTests).

For the other tests the message on skipping was updated to contain more information as to what causes them to be irrelevant on Windows.

Actions #1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47502

Actions #2

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47502

Actions #3

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47502

Actions #4

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47502

Actions #5

Updated by Susanne Moog over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47536

Actions #7

Updated by Susanne Moog over 8 years ago

  • Status changed from Under Review to Resolved
Actions #8

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF